feat: add PPXA and ConsensusADMM algorithms #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n and tests - Parallel Proximal Algorithm (PPXA) for minimizing the sum of proximable functions - ConsensusADMM for solving the global consensus problem with ADMM - add tests in test_solver.py - test_ConsensusADMM_with_ADMM - test_ConsensusADMM_with_ADMM_for_Lasso - test_ConsensusADMM_with_GPG - test_PPXA_with_ADMM - test_PPXA_with_GPG
Contributor
|
Thanks @tttamaki, will take a look soon and provide my review 😄 |
primal.py - prox_ops --> proxfs - np --> numpy - fix description of niter - remove () in math superscripts - add some comments test_solver.py - change niter to fit each test with seeds 0 to 499 - change tau to random value - change the order of argments to assert_array_almost_equal (actual <--> desired)
mrava87
approved these changes
Jan 5, 2026
Contributor
Author
|
@mrava87 Thanks for a quick merge! Now I can use these solvers as official ones :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the following two optimizers, both for minimizing the sum of prox operators.
also I added some tests with existing ADMM and GeneralizedProximalGradient.
The function of these optimizers is similar to GeneralizedProximalGradient, but more common in books and hence better to be implemented.